Merged
Conversation
5a3c364 to
3acd3ea
Compare
ea95a18 to
21c349a
Compare
sloretz
reviewed
Nov 15, 2018
Contributor
sloretz
left a comment
There was a problem hiding this comment.
Seems fine to me.
I played around with it locally using
import os
path = os.path.dirname(__file__)
with open(os.path.join(path, 'grammar.lark')) as fin:
grammar = fin.read()
from lark import Lark
parser = Lark(grammar, start='specification')
import code
code.interact(local=locals())
There are some odd things that I assume will be caught by something after the parser, like any literal can be assigned to any type.
# Parser accepts this
parser.parse('const double not_a_double = "Hello World";')
Member
Author
Correct, that kind of check is out of scope for the grammar. |
sloretz
approved these changes
Nov 15, 2018
Member
Author
|
I disabled the |
868bace to
95b264f
Compare
95b264f to
8a2e80d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fourth PR integrating #298 step-by-step.
Builds on top of #324.
The grammar covers a subset of the IDL spec.
Linux CI: