Skip to content

install lark-parser#220

Merged
dirk-thomas merged 3 commits intomasterfrom
lark-parser
Nov 16, 2018
Merged

install lark-parser#220
dirk-thomas merged 3 commits intomasterfrom
lark-parser

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Install the Python package lark-parser to parse IDL files.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 15, 2018
@dirk-thomas dirk-thomas self-assigned this Nov 15, 2018
@dirk-thomas
Copy link
Copy Markdown
Member Author

It turns our the latest release isn't going to cut it. We need the earley_sppf branch from the repo which might make it into a future version 0.7.

  1. Should we install the branch via pip install git+https://.../lark.git@earley_sppf and create a Debian package of that state for the Linux releases?
  2. Or should be create a vendor package instead (likely a fork of the upstream repo/branch with a package.xml file added)?

@jacobperron
Copy link
Copy Markdown
Member

  1. Should we install the branch via pip install git+https://.../lark.git@earley_sppf and create a Debian package of that state for the Linux releases?
  2. Or should be create a vendor package instead (likely a fork of the upstream repo/branch with a package.xml file added)?

🤔 Whichever is less work? In any case I presume we'll want to switch to a future version upstream when possible.

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Nov 15, 2018

Option 1. is certainly what we want long term. Creating the Debian package is some effort but once there is a released version with the state we need we can even push that one into Debian if we want to.

@jacobperron
Copy link
Copy Markdown
Member

I haven't looked too closely at commits, but would it make more sense to use a more recent branch like 0.7 or 0.7b? Then we'll hopefully closer match the next release version when it's ready. earley_sppf is 68 commits behind.

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Nov 15, 2018

Both of the branches do work for us (0.7, 0.7b). Not sure which one we want to choose - they have different commit(s) on them. (I asked upstream...)

@dirk-thomas
Copy link
Copy Markdown
Member Author

I updated the patch to use the branch 0.7b recommended by upstream.

Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros2/rosidl#326 test pass for me locally after running pip3 install git+https://github.com/lark-parser/lark.git@0.7b

@dirk-thomas dirk-thomas merged commit d54ba9a into master Nov 16, 2018
@dirk-thomas dirk-thomas deleted the lark-parser branch November 16, 2018 17:56
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants