Only pass one regular expression to filter topics#1053
Merged
MichaelOrlov merged 1 commit intoros2:rollingfrom Aug 3, 2022
Merged
Only pass one regular expression to filter topics#1053MichaelOrlov merged 1 commit intoros2:rollingfrom
MichaelOrlov merged 1 commit intoros2:rollingfrom
Conversation
This was referenced Aug 1, 2022
Contributor
|
@esteve CI failing in multiple tests related to the topics filtering https://build.ros2.org/job/Rpr__rosbag2__ubuntu_jammy_amd64/175/testReport/ |
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
7a15764 to
9948633
Compare
MichaelOrlov
approved these changes
Aug 2, 2022
Contributor
MichaelOrlov
left a comment
There was a problem hiding this comment.
@esteve LGTM. Thank you for your contribution!
Contributor
|
Running CI:
|
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 3, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Merged
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Generate changelogs for rosbag2 0.17.0 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update rosbag2_compression_zstd/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_compression/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_cpp/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_storage/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_transport/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Remove `instead` word in description of the #1010 in changelogs Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs with #1053 after rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs details in regard to the optimization in writer Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Generate changelogs for rosbag2 0.17.0 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update rosbag2_compression_zstd/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_compression/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_cpp/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_storage/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_transport/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Remove `instead` word in description of the #1010 in changelogs Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs with #1053 after rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs details in regard to the optimization in writer Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the
--regexoption works so that only one regular expression is passed to filter topics