Speed optimization: Preparing copyless publish/subscribing by using const message for writing#1010
Merged
MichaelOrlov merged 5 commits intoros2:rollingfrom Jul 28, 2022
Merged
Conversation
7d2694b to
3dc9ad6
Compare
added 3 commits
May 12, 2022 08:25
* changed to const * updated compression to make copy instead of in-place * removed copying data by refrencing to received message Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
3dc9ad6 to
780b95d
Compare
Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
MichaelOrlov
approved these changes
Jul 26, 2022
Contributor
MichaelOrlov
left a comment
There was a problem hiding this comment.
@DensoADAS Thanks for your contribution. LGTM.
Contributor
|
Running CI:
|
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 3, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Generate changelogs for rosbag2 0.17.0 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update rosbag2_compression_zstd/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_compression/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_cpp/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_storage/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_transport/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Remove `instead` word in description of the #1010 in changelogs Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs with #1053 after rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs details in regard to the optimization in writer Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Generate changelogs for rosbag2 0.17.0 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update rosbag2_compression_zstd/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_compression/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_cpp/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_storage/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Update rosbag2_transport/CHANGELOG.rst Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Remove `instead` word in description of the #1010 in changelogs Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs with #1053 after rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Update changelogs details in regard to the optimization in writer Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-8-18-2022/27050/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared rosbag for intraprocess communication for serialized messages without copying data by using const modifier. We have already a unit test proofing that it works, but we need to update rclcpp for enabling IPM with serialized message (PR in preparation).
Anyway I think modifying subscription to const shows that recording does not alter the data.