Merged
Conversation
The verb is redundant with 'ros2 interface show'. Equivalent tests for the ones removed already exist in ros2interface. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
Edit: re-triggered with 6ff9d4a |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
|
In contrast to #407 the removed verb was not deprecated before. I am not objecting to remove it - just wondering why it wasn't / if it should be deprecated in Eloquent? |
Member
Author
It was overlooked. I can open a separate PR against |
Member
That would be nice to match the |
dirk-thomas
approved these changes
Dec 2, 2019
Member
Author
|
Deprecating in Eloquent: #413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verb is redundant with 'ros2 interface show'.
Equivalent tests for the ones removed already exist in ros2interface.
Connects to #218