Merged
Conversation
Both packages were deprecated in Eloquent, superceded by ros2interface. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
I'm pretty sure there's no places left in our core packages referencing these packages, so I'm inclined to skip CI. |
hidmic
approved these changes
Dec 3, 2019
hidmic
left a comment
There was a problem hiding this comment.
LGTM, though I'm inclined to at least do one sanity check:
- Linux
Member
Author
|
@hidmic Correct me if I'm mistaken, but it looks like the CI job failures are all present in the latest nightly. |
Member
Author
|
I'm fairly certain none of the test failures are due to the removal of ros2msg and ros2srv. If I've overlooked something, I'll fix it in post. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both packages were deprecated in Eloquent, superceded by ros2interface.