Subordinate nodes note for Kilted Kaiju.#5426
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Apr 30, 2025
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
@christophebedard can you review this?
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14782965745/artifacts/3046838243. To view the resulting site:
|
kscottz
requested changes
May 1, 2025
Collaborator
kscottz
left a comment
There was a problem hiding this comment.
I would like just a smidge more context here for less versed developers.
4 tasks
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
christophebedard
approved these changes
May 1, 2025
Collaborator
Author
|
@kscottz can you review the latest fix? |
kscottz
approved these changes
May 2, 2025
Collaborator
|
LGTM |
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2025
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2025
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2025
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
ahcorde
pushed a commit
that referenced
this pull request
May 2, 2025
ahcorde
pushed a commit
that referenced
this pull request
May 2, 2025
ahcorde
pushed a commit
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aligns with ros2/rclcpp#2830