subordinate node consistent behavior and update docstring. (backport #2822)#2830
Merged
fujitatomoya merged 1 commit intokiltedfrom Apr 30, 2025
Merged
subordinate node consistent behavior and update docstring. (backport #2822)#2830fujitatomoya merged 1 commit intokiltedfrom
fujitatomoya merged 1 commit intokiltedfrom
Conversation
* subordinate node consistent behavior and update docstring. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add subnode_parameter_operation test. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * typo fixes. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit c89a2b1)
fujitatomoya
approved these changes
Apr 29, 2025
Collaborator
|
Pulls: #2830
|
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2795
Note
extend_name_with_sub_namespaceis inline function, so user must rebuild the application with rclcpp to get this fix. besides that, this is behavior change could break the application. i am not inclined to backport this. thoughts?This is an automatic backport of pull request #2822 done by Mergify.