Skip to content

subordinate node consistent behavior and update docstring.#2822

Merged
fujitatomoya merged 3 commits intorollingfrom
fujitatomoya/sub-node-fix
Apr 29, 2025
Merged

subordinate node consistent behavior and update docstring.#2822
fujitatomoya merged 3 commits intorollingfrom
fujitatomoya/sub-node-fix

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Apr 21, 2025 •
edited
Loading

closes #2795

Note

extend_name_with_sub_namespace is inline function, so user must rebuild the application with rclcpp to get this fix. besides that, this is behavior change could break the application. i am not inclined to backport this. thoughts?

@fujitatomoya
subordinate node consistent behavior and update docstring.
4df60cf 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
add subnode_parameter_operation test.
248fdcc 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Apr 21, 2025
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 21, 2025

@jmachowinski @mjcarroll can you review this?

christophebedard
christophebedard reviewed Apr 21, 2025
View reviewed changes
@fujitatomoya
typo fixes.
a705ccc 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 22, 2025

Pulls: #2822
Gist: https://gist.githubusercontent.com/fujitatomoya/4eae4734591a7b22690e7f7ed0abbcde/raw/defed4a27eb0e0fbfaab46dd7fc7a787ef29f8b6/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15726

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-assigned this Apr 22, 2025
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 22, 2025

We can probably get this into Rolling during the freeze, before Kilted branches off (which it hasn't yet IIUC).

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 22, 2025

@christophebedard what do you think about backport ? #2822 (comment)

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 22, 2025

Yeah, I agree, maybe we should hold off on backporting, at least for now. This is the kind of issue that users probably worked around. If someone requests a backport, then we can consider it more seriously.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 22, 2025

Warning

DO NOT MERGE THIS, WE ARE NOW BRANCHING KILTED.

@fujitatomoya fujitatomoya merged commit c89a2b1 into rolling Apr 29, 2025
2 of 3 checks passed
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 29, 2025

@Mergifyio backport kilted

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 29, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 29, 2025
@fujitatomoya @mergify
subordinate node consistent behavior and update docstring. (#2822)
918ddf9 
* subordinate node consistent behavior and update docstring.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* add subnode_parameter_operation test.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* typo fixes.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit c89a2b1)
@mergify mergify bot mentioned this pull request Apr 29, 2025
Merged
fujitatomoya added a commit that referenced this pull request Apr 30, 2025
@mergify @fujitatomoya
subordinate node consistent behavior and update docstring. (#2822) (#…
93028ff 
…2830)

* subordinate node consistent behavior and update docstring.



* add subnode_parameter_operation test.



* typo fixes.



---------


(cherry picked from commit c89a2b1)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@christophebedard christophebedard mentioned this pull request Apr 30, 2025
Merged
@christophebedard christophebedard deleted the fujitatomoya/sub-node-fix branch April 30, 2025 15:40
@mergify mergify bot mentioned this pull request Apr 30, 2025
Merged
@nirwester nirwester mentioned this pull request Jun 2, 2025
Closed
@DLu
Copy link
Copy Markdown

DLu commented Jun 2, 2025

Is there a tutorial on how to use this yet? :-D

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jun 2, 2025

Not as far as I know, but I opened an issue for that here: ros2/ros2_documentation#5457.

@jonbinney jonbinney mentioned this pull request Sep 19, 2025
Open
@v-lopez
Copy link
Copy Markdown

v-lopez commented Oct 29, 2025

Is there a chance to have this backported to jazzy? Or a workaround for it?

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 1, 2025

@v-lopez unfortunately i do not think so, as the PR header says this breaks the user space. it looks like we did backport this to kilted, but it is different situation. for kilted, we were just working on the branching from rolling, so that is not counted as backport.

@peci1 peci1 mentioned this pull request Dec 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

@christophebedard christophebedard christophebedard approved these changes

@jmachowinski jmachowinski Awaiting requested review from jmachowinski

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rclcpp::Node::get_parameter overloads undocumented inconsistent behavior

5 participants

@fujitatomoya @christophebedard @DLu @v-lopez @wjwwood