Skip to content

Significantly clean up and expand the documentation about logging.#3025

Merged
clalancette merged 1 commit intorollingfrom
clalancette/cleanup-logging-docs
Sep 23, 2022
Merged

Significantly clean up and expand the documentation about logging.#3025
clalancette merged 1 commit intorollingfrom
clalancette/cleanup-logging-docs

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

@clalancette clalancette commented Sep 16, 2022

Explain a lot more about which APIs to use, which configuration options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This PR incorporates parts of, and should supersede, #2028 , #2996 , and #2978 . @fujitatomoya @tfoote @tylerjw please take a look

@clalancette
Significantly clean up and expand the documentation about logging.
e64adeb 
Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
fujitatomoya
fujitatomoya reviewed Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for organizing!

@fujitatomoya fujitatomoya mentioned this pull request Sep 22, 2022
Closed
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 23, 2022
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Sep 23, 2022

Thanks for the review! I'm going to merge this and backport it.

@clalancette clalancette merged commit c23fff0 into rolling Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/cleanup-logging-docs branch September 23, 2022 12:48
@mergify mergify bot mentioned this pull request Sep 23, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
@clalancette @mergify
Significantly clean up and expand the documentation about logging. (#…
61930ad 
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)
@mergify mergify bot mentioned this pull request Sep 23, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
@clalancette @mergify
Significantly clean up and expand the documentation about logging. (#…
2cb012e 
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
@clalancette @mergify
Significantly clean up and expand the documentation about logging. (#…
62ce48d 
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)
@mergify mergify bot mentioned this pull request Sep 23, 2022
Merged
@clalancette clalancette mentioned this pull request Sep 23, 2022
Closed
clalancette added a commit that referenced this pull request Sep 23, 2022
@mergify @clalancette
Significantly clean up and expand the documentation about logging. (#…
79513a9 
…3025) (#3032)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Sep 23, 2022
@mergify @clalancette
Significantly clean up and expand the documentation about logging. (#…
37c4c9b 
…3025) (#3033)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Sep 23, 2022
@mergify @clalancette
Significantly clean up and expand the documentation about logging. (#…
74fe83b 
…3025) (#3034)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette mentioned this pull request Sep 28, 2022
Closed
@clalancette clalancette mentioned this pull request Oct 12, 2022
Open
@clalancette clalancette mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clalancette @fujitatomoya