Skip to content

Add topic statistics dependency#897

Merged
wjwwood merged 2 commits intoros2:masterfrom
aws-ros-dev:prajaktg/add-topic-stats-dependency
Apr 18, 2020
Merged

Add topic statistics dependency#897
wjwwood merged 2 commits intoros2:masterfrom
aws-ros-dev:prajaktg/add-topic-stats-dependency

Conversation

@prajakta-gokhale
Copy link
Copy Markdown

@prajakta-gokhale prajakta-gokhale commented Apr 15, 2020 •
edited
Loading

Prajakta Gokhale added 2 commits April 14, 2020 18:40
Add topic statistics dependency
17cfcdf 
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Add topic statistics dependency
f2a75ff 
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
@prajakta-gokhale prajakta-gokhale mentioned this pull request Apr 15, 2020
Closed
@dabonnie dabonnie mentioned this pull request Apr 16, 2020
Closed
9 tasks
@prajakta-gokhale prajakta-gokhale marked this pull request as ready for review April 17, 2020 02:44
@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 17, 2020

CI up-to new package:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 17, 2020

@wjwwood please take a look!

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 17, 2020

Looks like there's a test failure: https://ci.ros2.org/job/ci_linux/10269/testReport/junit/(root)/projectroot/copyright/

@dabonnie
Copy link
Copy Markdown

dabonnie commented Apr 17, 2020 •
edited
Loading

@wjwwood Should be gtg with the most recent PR (thanks @emersonknapp!).

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 17, 2020

Please rerun CI.

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 17, 2020 •
edited
Loading

Rerun after copyright fix:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Fixed Windows errors:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 17, 2020 •
edited
Loading

@wjwwood all test failures are now fixed. Windows WARNING is also fixed in ros-tooling/libstatistics_collector#6.

@dabonnie dabonnie mentioned this pull request Apr 17, 2020
Merged
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 18, 2020

Is this new compiler warning on Windows not due to this pr? https://ci.ros2.org/job/ci_windows/10185/msbuild/new/

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 18, 2020 •
edited
Loading

Is this new compiler warning on Windows not due to this pr? https://ci.ros2.org/job/ci_windows/10185/msbuild/new/

Yes, that is the one fixed in ros-tooling/libstatistics_collector#6. That PR got merged after the latest CI. I'll rerun it so the warning is gone.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 18, 2020

Ah, have you run CI since then? I just really don't want to merge something that takes us backwards towards green CI after all the work folks have put into getting it green again.

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 18, 2020

With latest changes:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@prajakta-gokhale
Copy link
Copy Markdown
Author

prajakta-gokhale commented Apr 18, 2020

Ah, have you run CI since then? I just really don't want to merge something that takes us backwards towards green CI after all the work folks have put into getting it green again.

That's fair. Started another round of CI which should have no new warnings.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 18, 2020

Thanks I'll keep an eye out and merge it when it's back.

@wjwwood wjwwood merged commit 5086f24 into ros2:master Apr 18, 2020
@prajakta-gokhale prajakta-gokhale mentioned this pull request Apr 18, 2020
Merged
@prajakta-gokhale prajakta-gokhale deleted the prajaktg/add-topic-stats-dependency branch April 19, 2020 00:00
Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
Add topic statistics dependency (ros2#897)
862df8d 
* Add topic statistics dependency

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add topic statistics dependency

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prajakta-gokhale @wjwwood @dabonnie