Add new messages for topic statistics#98
Merged
dirk-thomas merged 3 commits intoros2:masterfrom Apr 17, 2020
Merged
Conversation
added 2 commits
April 16, 2020 15:15
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
dirk-thomas
reviewed
Apr 16, 2020
dirk-thomas
reviewed
Apr 16, 2020
dirk-thomas
reviewed
Apr 16, 2020
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
9 tasks
3 tasks
Author
|
wjwwood
approved these changes
Apr 16, 2020
|
@dirk-thomas re-review please? |
dirk-thomas
reviewed
Apr 17, 2020
| # Constant for uninitialized | ||
| uint8 STATISTICS_DATA_TYPE_UNINITIALIZED = 0 | ||
|
|
||
| # Allowed values |
Member
There was a problem hiding this comment.
It would be good to check the generated code on how these comments appear in docblocks. I would guess this one will be associated with the first enum which seems weird.
dirk-thomas
approved these changes
Apr 17, 2020
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
My comment about the "comments" doesn't need to block the merge. It can be followed up on afterwards if necessary.
Sounds good. Who can perform the merge? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new messages required for topic statistics.