Skip to content

Add ros2/launch_ros repository to ros2.repos#676

Merged
hidmic merged 1 commit intomasterfrom
hidmic/add-launch-ros
Mar 22, 2019
Merged

Add ros2/launch_ros repository to ros2.repos#676
hidmic merged 1 commit intomasterfrom
hidmic/add-launch-ros

Conversation

@hidmic
Copy link
Copy Markdown

@hidmic hidmic commented Mar 21, 2019

Precisely what the title says.

This PR depends on ros2/launch_ros#1 and ros2/launch#211 and as such should only be merged after them.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from wjwwood March 21, 2019 19:42
@hidmic hidmic added the in progress Actively being worked on (Kanban column) label Mar 21, 2019
@hidmic hidmic added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 21, 2019
@hidmic
Copy link
Copy Markdown
Author

hidmic commented Mar 21, 2019

I'll get the word out once this is merged.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 21, 2019

This PR depends on ros2/launch_ros#1 and ros2/launch#211 and as such should only be merged after them.

It should be merged at the same time as them, otherwise people will be missing required packages from ros2/launch.

@hidmic hidmic merged commit 1f43d4a into master Mar 22, 2019
@hidmic hidmic deleted the hidmic/add-launch-ros branch March 22, 2019 17:26
@hidmic hidmic removed the in review Waiting for review (Kanban column) label Mar 22, 2019
Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants