Skip to content

remove ROS specific launch packages which were moved to ros2/launch_ros#211

Merged
hidmic merged 1 commit intomasterfrom
import_from_launch
Mar 22, 2019
Merged

remove ROS specific launch packages which were moved to ros2/launch_ros#211
hidmic merged 1 commit intomasterfrom
import_from_launch

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Mar 21, 2019

Connects to ros2/launch_ros#1

…/launch_ros

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood self-assigned this Mar 21, 2019
@wjwwood wjwwood requested a review from hidmic March 21, 2019 19:12
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 21, 2019
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Copy Markdown

hidmic commented Mar 21, 2019

CI (full run):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit abaa861 into master Mar 22, 2019
@hidmic hidmic removed the in review Waiting for review (Kanban column) label Mar 22, 2019
@hidmic hidmic deleted the import_from_launch branch March 22, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants