Skip to content

Set Fast CDR and Fast DDS branches to master#1241

Merged
clalancette merged 1 commit intoros2:masterfrom
eProsima:use-fast-dds-master
Mar 7, 2022
Merged

Set Fast CDR and Fast DDS branches to master#1241
clalancette merged 1 commit intoros2:masterfrom
eProsima:use-fast-dds-master

Conversation

@MiguelCompany
Copy link
Copy Markdown
Contributor

New features for humble like content filter and on_sample_lost will only be present from Fast DDS 2.6.0 (due March 14, 2022) onwards.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@fujitatomoya
Copy link
Copy Markdown
Contributor

required from ros2/design#282, Content Filtered Topic ROS 2.

@clalancette
Copy link
Copy Markdown
Contributor

In general I'm OK with this, but I want to hold off until we've done the transition to Jammy and have things on the buildfarm stabilized a bit. Hopefully later this week.

@nuclearsandwich
Copy link
Copy Markdown
Member

I became very interested in this today because the current version of Fast-RTPS released in Rolling (2.3.4) does not build on Ubuntu Jammy

Here is Ubuntu Jammy CI

  • Ubuntu Jammy Build Status
  • Ubuntu Jammy aarch64 Build Status
  • Ubuntu Focal Build Status
  • Ubuntu Focal aarch64 Build Status
  • Windows Build Status

@nuclearsandwich
Copy link
Copy Markdown
Member

Windows job failed due to agent disconnection Build Status

@EduPonz
Copy link
Copy Markdown

EduPonz commented Feb 28, 2022

@clalancette @nuclearsandwich Friendly ping. It'd be great to have this merged as soon as possible since it enables CFT (ros2/design#282). Besides, ROS 2 Humble will ship Fast DDS v2.6.0, which will branch out from master in a couple of weeks, so I really think that we should run some nightlies on master before that.

CC: @fujitatomoya @MiguelCompany

@clalancette
Copy link
Copy Markdown
Contributor

Here's another full CI to see where we are at:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Contributor

CC: @iuhilnehc-ynos Just FYI, this is a PR for Fast-DDS CFT feature to ROS 2. we need to align with this PR.

@clalancette
Copy link
Copy Markdown
Contributor

@EduPonz FYI, the CI on Linux looks like there are some failing tests that are not in the nightlies. If we compare the results on Linux to those on https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2220/ (which is the closest nightly analog), it looks like there are 8 new regressions. Can you look into those?

@nuclearsandwich nuclearsandwich self-assigned this Mar 1, 2022
@nuclearsandwich
Copy link
Copy Markdown
Member

Self-assigning to make sure that I keep tabs on the momentum here but I'm not doing any work towards resolving the test failures clalancette mentioned as its beyond my current knowledge.

@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 1, 2022

Can you look into those?

Sure, we will look into those. Thanks guys!

@MiguelCompany
Copy link
Copy Markdown
Contributor Author

@clalancette @nuclearsandwich We've tracked this down to an issue in Fast DDS, which is being fixed on eProsima/Fast-DDS#2544.

While debugging this, I also found that an improvement on rmw_fastrtps could be made (ros2/rmw_fastrtps#586). That improvement did also fix the failing tests here.

The tests pass with any of those PRs in.

@MiguelCompany
Copy link
Copy Markdown
Contributor Author

@clalancette PR eProsima/Fast-DDS#2544 has been merged, so the tests on this one should pass now

@clalancette
Copy link
Copy Markdown
Contributor

ros2/rmw_fastrtps#586 has a lot of new failures that need to be looked into. That said, it looks like either that PR or the one in Fast-DDS itself should have solved the issue, so here's another run with just switching to Fast-DDS master branch to see what the situation looks like:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 2, 2022

@clalancette What do you think?

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Mar 2, 2022

The warnings on Linux-aarch64 are known, and all of the failures shown on Windows have been seen at least once in the last month. So I think that much is good. Here are some additional jobs to see how things look:

  • Windows Debug Build Status
  • RHEL Build Status
  • Packaging Linux Build Status
  • Packaging Linux aarch64 Build Status
  • Packaging Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

@EduPonz @MiguelCompany Overall, the CI for this looks good now. I'm hesitating to merge it because we can only do a binary release once we have a tagged version. That is, our source and binary releases will be divergent with respect to the Fast-DDS version in use. This is OK for a little while, but I'd like to understand the timeline for a planned 2.6.0 tag and release. Can you give me some approximate dates for when that is going to happen? Thanks.

@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 4, 2022

Can you give me some approximate dates for when that is going to happen?

Sure thing! Fast DDS v2.6.0 will be release somewhere between the 16th and the 18th March 2022. In fact, this 2.6 is the version we will include in Humble, thus it will be released prior to the RMW API freeze due to March the 21st. Is that OK with you?

@nuclearsandwich
Copy link
Copy Markdown
Member

In fact, this 2.6 is the version we will include in Humble, thus it will be released prior to the RMW API freeze due to March the 21st.

I can't speak for Chris but I really appreciate that y'all are working to adhere to the RMW API freeze deadline and factoring that into your release schedule. One of the big challenges for ROS 2's release schedule has been getting each of the components to come together at the right time to stabilize higher level components above them so I hope this works out well for all of us and let me know if you need any release support.

@clalancette
Copy link
Copy Markdown
Contributor

@EduPonz Thanks for the feedback, that is very helpful. As @nuclearsandwich says, we very much appreciate that you are being proactive about getting the new version of Fast-DDS available before the Humble freeze deadline.

With the state of CI here, I'm going to go ahead and merge this on Monday, March 7. I'm holding off over the weekend mostly so we are around to deal with any unexpected things that happen as a result of this merge.

@clalancette clalancette merged commit 9597c36 into ros2:master Mar 7, 2022
@MiguelCompany MiguelCompany deleted the use-fast-dds-master branch March 7, 2022 15:54
@MiguelCompany
Copy link
Copy Markdown
Contributor Author

@clalancette @nuclearsandwich We did the v2.6.0 release of Fast DDS yesterday, along with release v1.0.24 of Fast CDR.

I have tried to do a bloom-release -r rolling fastrtps --edit changing the devel branch to 2.6.x, but it failed with the following error.

==> git-bloom-generate -y rosrelease rolling --source upstream -i 1
Releasing package: ['fastrtps']
Releasing package 'fastrtps' for 'rolling' to: 'release/rolling/fastrtps'
 [git-bloom-patch import]: 'execute_command' failed to call 'git am /tmp/tmpc8svf2ak/*.patch' which had a return code (128):
 [git-bloom-patch import]: ```
error: patch failed: src/cpp/security/authentication/PKIDH.cpp:819
error: src/cpp/security/authentication/PKIDH.cpp: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: Apply OpenSSL 3.0 patches from upstream 2.3.x branch.
Patch failed at 0001 Apply OpenSSL 3.0 patches from upstream 2.3.x branch.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

 [git-bloom-patch import]: ```
 [git-bloom-patch import]: Failed to apply one or more patches for the 'Command 'git am /tmp/tmpc8svf2ak/*.patch' returned non-zero exit status 128.' branch.

Would you mind doing the bloom release for fastcdr and fastrtps ?

@clalancette
Copy link
Copy Markdown
Contributor

@MiguelCompany FYI, we did releases for these in ros/rosdistro#32482 and ros/rosdistro#32483 . We are probably going to wait to merge them until we get some other stuff released, but we'll merge it as a unit when it is all ready. Thanks.

@MiguelCompany
Copy link
Copy Markdown
Contributor Author

@clalancette Thanks!

Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants