Skip to content

Correct reporting of MatchedStatus last_*_handle [13786]#2544

Merged
MiguelCompany merged 2 commits intomasterfrom
bugfix/last_pubsub_handle
Mar 1, 2022
Merged

Correct reporting of MatchedStatus last_*_handle [13786]#2544
MiguelCompany merged 2 commits intomasterfrom
bugfix/last_pubsub_handle

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Mar 1, 2022 •
edited by MiguelCompany
Loading

Description

Prior to this PR, SubscriptionMatchedStatus::last_publication_handle and PublicationMatchedStatus::last_subscription_handle where only updated when a new matched occurred, but not when a remote DataWriter|DataReader was unmatched. According to the DDS specification, the last_*_handle should contain the InstanceHandle to the last entity that modified the status, which includes modifications by unmatching. This PR:

  1. Adds a regression test for the correct behaviour
  2. Correctly updates the last_*_handle both for DataReaders and DataWriters

@Mergifyio backport 2.5.x 2.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

EduPonz added 2 commits March 1, 2022 15:24
@EduPonz
Refs 13786: Add test for MatchedStatus last_*_handle
92013eb 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs 13786: Correct reporting of MatchedStatus last_*_handle
0d946bc 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz requested a review from MiguelCompany March 1, 2022 14:37
MiguelCompany
MiguelCompany approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany mentioned this pull request Mar 1, 2022
Merged
@MiguelCompany MiguelCompany merged commit ba01ca6 into master Mar 1, 2022
@MiguelCompany MiguelCompany deleted the bugfix/last_pubsub_handle branch March 1, 2022 20:18
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Mar 2, 2022

@Mergifyio backport 2.5.x 2.4.x

mergify bot pushed a commit that referenced this pull request Mar 2, 2022
@EduPonz
Correct reporting of MatchedStatus last_*_handle (#2544)
9d156fc 
* Refs 13786: Add test for MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs 13786: Correct reporting of MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
(cherry picked from commit ba01ca6)
@mergify mergify bot mentioned this pull request Mar 2, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 2, 2022
@EduPonz
Correct reporting of MatchedStatus last_*_handle (#2544)
c2a0b07 
* Refs 13786: Add test for MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs 13786: Correct reporting of MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
(cherry picked from commit ba01ca6)

# Conflicts:
#	test/blackbox/api/dds-pim/PubSubReader.hpp
#	test/blackbox/common/DDSBlackboxTestsDiscovery.cpp
@mergify mergify bot mentioned this pull request Mar 2, 2022
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 2, 2022

backport 2.5.x 2.4.x

✅ Backports have been created

Details

MiguelCompany pushed a commit that referenced this pull request Mar 3, 2022
@mergify @EduPonz
Correct reporting of MatchedStatus last_*_handle (#2547)
aada451 
* Correct reporting of MatchedStatus last_*_handle (#2544)

* Refs 13786: Add test for MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs 13786: Correct reporting of MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
(cherry picked from commit ba01ca6)

# Conflicts:
#	test/blackbox/api/dds-pim/PubSubReader.hpp
#	test/blackbox/common/DDSBlackboxTestsDiscovery.cpp

* Resolve backport conflicts

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @MiguelCompany