Skip to content

Correct reporting of MatchedStatus last_*_handle [13786] (backport #2544)#2547

Merged
MiguelCompany merged 2 commits into2.4.xfrom
mergify/bp/2.4.x/pr-2544
Mar 3, 2022
Merged

Correct reporting of MatchedStatus last_*_handle [13786] (backport #2544)#2547
MiguelCompany merged 2 commits into2.4.xfrom
mergify/bp/2.4.x/pr-2544

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 2, 2022

This is an automatic backport of pull request #2544 done by Mergify.
Cherry-pick of ba01ca6 has failed:

On branch mergify/bp/2.4.x/pr-2544
Your branch is up to date with 'origin/2.4.x'.

You are currently cherry-picking commit ba01ca6a8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/fastdds/publisher/DataWriterImpl.cpp
	modified:   src/cpp/fastdds/subscriber/DataReaderImpl.cpp
	modified:   test/blackbox/api/dds-pim/PubSubWriter.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/blackbox/api/dds-pim/PubSubReader.hpp
	both modified:   test/blackbox/common/DDSBlackboxTestsDiscovery.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Refs 13786: Add test for MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs 13786: Correct reporting of MatchedStatus last_*_handle

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
(cherry picked from commit ba01ca6)

# Conflicts:
#	test/blackbox/api/dds-pim/PubSubReader.hpp
#	test/blackbox/common/DDSBlackboxTestsDiscovery.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Mar 2, 2022
@MiguelCompany
Copy link
Copy Markdown
Member

@EduPonz Would you mind fixing conflicts here?

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 2, 2022

@EduPonz Would you mind fixing conflicts here?

Done in fbdab9b. Tests pass locally

@MiguelCompany MiguelCompany removed the conflicts Backport PR wich git cherry pick failed label Mar 2, 2022
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit aada451 into 2.4.x Mar 3, 2022
@MiguelCompany MiguelCompany deleted the mergify/bp/2.4.x/pr-2544 branch March 3, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants