Add test creating two content filter topics with the same topic name#230
Merged
ahcorde merged 2 commits intoros2:masterfrom Jun 3, 2024
Merged
Add test creating two content filter topics with the same topic name#230ahcorde merged 2 commits intoros2:masterfrom
ahcorde merged 2 commits intoros2:masterfrom
Conversation
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
This was referenced May 30, 2024
fujitatomoya
approved these changes
Jun 1, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Contributor
|
MiguelCompany
suggested changes
Jun 3, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Contributor
|
ahcorde
approved these changes
Jun 3, 2024
ahcorde
pushed a commit
that referenced
this pull request
Jun 4, 2024
…230) Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
This was referenced Jun 5, 2024
Merged
Merged
Merged
ahcorde
added a commit
that referenced
this pull request
Jun 6, 2024
…230) (#233) (#237) Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> (cherry picked from commit 16e14d1) Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya
added a commit
that referenced
this pull request
Jun 7, 2024
…… (backport #233) (#235) * Add test creating two content filter topics with the same topic name (#230) (#233) Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> (cherry picked from commit 16e14d1) * build test for each rmw implementation. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
Jun 12, 2024
…… (backport #233) (#236) * Add test creating two content filter topics with the same topic name (#230) (#233) Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> (cherry picked from commit 16e14d1) * build test for each rmw implementation. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the proper test in
test_rmw_implementationthat checks for a successful creation of two content filter topics for the same topic name.