Skip to content

Add test creating two content filter topics with the same topic name … (backport #233)#235

Merged
fujitatomoya merged 2 commits intoironfrom
mergify/bp/iron/pr-233
Jun 7, 2024
Merged

Add test creating two content filter topics with the same topic name … (backport #233)#235
fujitatomoya merged 2 commits intoironfrom
mergify/bp/iron/pr-233

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jun 5, 2024

I wrongly merged this PR #230 on master. This PR targets rolling

This is an automatic backport of pull request #233 done by Mergify.

@ahcorde @Mario-DL @mergify
Add test creating two content filter topics with the same topic name (#…
6963676 
…230) (#233)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 16e14d1)
@mergify mergify bot requested a review from wjwwood as a code owner June 5, 2024 21:18
@mergify mergify bot mentioned this pull request Jun 5, 2024
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jun 5, 2024 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

this failed because 513f670 is missing in iron and humble. since 513f670 is just enhancement for building, i am not gonna backport that to iron and humble.

@fujitatomoya
build test for each rmw implementation.
43bd1bd 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jun 6, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Jun 6, 2024
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jun 7, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit b2251c9 into iron Jun 7, 2024
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-233 branch June 7, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @ahcorde