Skip to content

Add client/service QoS getters#196

Merged
ivanpauno merged 3 commits intoros2:masterfrom
mauropasse:mauro/add-qos-getters-cli-serv
Nov 19, 2021
Merged

Add client/service QoS getters#196
ivanpauno merged 3 commits intoros2:masterfrom
mauropasse:mauro/add-qos-getters-cli-serv

Conversation

@mauropasse
Copy link
Copy Markdown
Contributor

@mauropasse mauropasse commented Sep 24, 2021 •
edited
Loading

Add client/service QoS getters
3af090d 
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
This was referenced Sep 24, 2021
Merged
Merged
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Sep 29, 2021

test would be nice to add.

@clalancette clalancette added the more-information-needed Further information is required label Oct 14, 2021
Mauro Passerino added 2 commits October 21, 2021 18:15
Add Client/Service QoS unit test
887d360 
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Add serv/cli request/response qos getters
d15870e 
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
@mauropasse
Copy link
Copy Markdown
Contributor Author

mauropasse commented Nov 1, 2021

After some discussion (see ros2/rmw_connextdds#67 (comment)) I updated all PRs to retrieve independently the QoS for Client request publisher / response subscription and Services request subscription / response publisher.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Nov 1, 2021 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

PRs being tested: ros2/rmw_fastrtps#560, ros2/rmw_cyclonedds#343, ros2/rmw_connextdds#67, ros2/rmw#314 and this one.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Nov 1, 2021

Extra CI run to check linter issues were solved:

  • Linux Build Status

All the rmw* PRs look ready to me, I wIll wait for another opinion on the proposed API before merging.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Nov 19, 2021

Rpr checker will continue failing until I release rmw, rmw_fastrtps, rmw_connextdds, rmw_cyclonedds.
I will merge this PR and then do that.

@ivanpauno ivanpauno merged commit 679b120 into ros2:master Nov 19, 2021
This was referenced Nov 19, 2021
Merged
Merged
Merged
@Blast545
Copy link
Copy Markdown
Contributor

Blast545 commented Nov 23, 2021

👨‍🌾 This PR introduced some linter test regressions into the buildfarm: https://ci.ros2.org/job/nightly_linux_debug/2120/#showFailuresLink.

The linter check job didn't include the package test_rmw_implementation which was modified as well.

@Blast545 Blast545 mentioned this pull request Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

more-information-needed Further information is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mauropasse @fujitatomoya @ivanpauno @Blast545 @clalancette