Merged
Conversation
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
This was referenced Sep 24, 2021
ivanpauno
approved these changes
Oct 26, 2021
Member
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the contribution @mauropasse
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Contributor
Author
|
After some discussion (see ros2/rmw_connextdds#67 (comment)) I updated all PRs to retrieve independently the QoS for Client request publisher / response subscription and Services request subscription / response publisher. |
ivanpauno
approved these changes
Nov 1, 2021
Member
Member
|
I have already discussed this with other members of the ROS 2 team and the proposed API looks fine. |
Member
87 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by:
ros2/rmw_fastrtps#560
ros2/rmw_implementation#196
Signed-off-by: Mauro Passerino mpasserino@irobot.com