Skip to content

Add deprecation warning for FASTRTPS_DEFAULT_PROFILES_FILE#806

Merged
fujitatomoya merged 4 commits intoros2:rollingfrom
Carlosespicur:hotfix/deprecated-qos-env
Feb 26, 2025
Merged

Add deprecation warning for FASTRTPS_DEFAULT_PROFILES_FILE#806
fujitatomoya merged 4 commits intoros2:rollingfrom
Carlosespicur:hotfix/deprecated-qos-env

Conversation

@Carlosespicur
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur commented Feb 18, 2025

Main Changes

This PR adds a deprecation warning for FASTRTPS_DEFAULT_PROFILES_FILE environment variable. According to Fast DDS v3 documentation, it has been renamed to FASTDDS_DEFAULT_PROFILES_FILE.

@Carlosespicur Carlosespicur force-pushed the hotfix/deprecated-qos-env branch 6 times, most recently from 69e76fe to 692cc1a Compare February 18, 2025 14:04
@Carlosespicur
Add deprecation warning for FASTRTPS_DEFAULT_PROFILES_FILE
9a087d2 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the hotfix/deprecated-qos-env branch from 692cc1a to 9a087d2 Compare February 18, 2025 14:33
MiguelCompany
MiguelCompany requested changes Feb 18, 2025
View reviewed changes
@Carlosespicur
Apply suggested changes
c289b49 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
fujitatomoya
fujitatomoya approved these changes Feb 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 24, 2025

@MiguelCompany rpr jobs is failing, is this expected because released rolling is older than mainline head?

@fujitatomoya fujitatomoya mentioned this pull request Feb 24, 2025
Merged
@MiguelCompany
Copy link
Copy Markdown
Collaborator

MiguelCompany commented Feb 25, 2025

@MiguelCompany rpr jobs is failing, is this expected because released rolling is older than mainline head?

Yeah, we don't yet have a fastdds 3.x package released

@Carlosespicur
Apply suggested changes
1848ef2 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Fix style errors
7b62f43 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 25, 2025

Pulls: ros2/rcl#1211, #806
Gist: https://gist.githubusercontent.com/fujitatomoya/34e26c37c2ecee219239b6ed1b80c275/raw/73e95dd88a813ad6e6ee57f1ca6e11a6c5731031/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rcl rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15244

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 25, 2025

we should skip 'rmw_fastrtps_dynamic_cpp'.

https://ci.ros2.org/job/ci_linux-aarch64/16832/console

Package 'rmw_fastrtps_dynamic_cpp' specified with --packages-above-and-dependencies was not found

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 25, 2025

Pulls: ros2/rcl#1211, #806
Gist: https://gist.githubusercontent.com/fujitatomoya/e64f816071d4a4667b99a29b095410d0/raw/73e95dd88a813ad6e6ee57f1ca6e11a6c5731031/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rcl rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15245

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 772aee1 into ros2:rolling Feb 26, 2025
2 of 3 checks passed
@christophebedard christophebedard mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Carlosespicur @fujitatomoya @MiguelCompany