Skip to content

Use FASTDDS_DEFAULT_PROFILES_FILE instead.#1211

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/deprecated-fastrtps-env-xml
Feb 26, 2025
Merged

Use FASTDDS_DEFAULT_PROFILES_FILE instead.#1211
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/deprecated-fastrtps-env-xml

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Feb 24, 2025

aligns with ros2/rmw_fastrtps#806

@fujitatomoya
Use FASTDDS_DEFAULT_PROFILES_FILE instead.
ac41d1f 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Feb 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not have to wait for ros2/rmw_fastrtps#806, but would be nice to merge them all together.

@MiguelCompany @Carlosespicur

@fujitatomoya fujitatomoya self-assigned this Feb 24, 2025
MiguelCompany
MiguelCompany approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @fujitatomoya!

@MiguelCompany
Copy link
Copy Markdown
Contributor

MiguelCompany commented Feb 25, 2025

this does not have to wait for ros2/rmw_fastrtps#806, but would be nice to merge them all together.

@fujitatomoya I suggest to run CI for both this and ros2/rmw_fastrtps#806 so we can merge them together

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Feb 25, 2025

Pulls: #1211, ros2/rmw_fastrtps#806
Gist: https://gist.githubusercontent.com/fujitatomoya/34e26c37c2ecee219239b6ed1b80c275/raw/73e95dd88a813ad6e6ee57f1ca6e11a6c5731031/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rcl rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15244

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Feb 25, 2025
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Feb 25, 2025

Pulls: #1211, ros2/rmw_fastrtps#806
Gist: https://gist.githubusercontent.com/fujitatomoya/e64f816071d4a4667b99a29b095410d0/raw/73e95dd88a813ad6e6ee57f1ca6e11a6c5731031/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rcl rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15245

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit bfcf66d into rolling Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

1 more reviewer

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @MiguelCompany