Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
commented
Jun 25, 2020
| EXPECT_FALSE(called); | ||
| } | ||
|
|
||
| TEST(test_scope_exit, code_types) { |
Author
There was a problem hiding this comment.
If anybody has a nice way to "test" signatures in compile time (w/o an actual bare test), I'm all ears.
wjwwood
approved these changes
Jun 25, 2020
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, we should remove the one in rclcpp and use this instead.
Author
|
CI up to
|
Author
Will do, but I want the original |
ivanpauno
approved these changes
Jun 25, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Jun 25, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Jun 26, 2020
fujitatomoya
approved these changes
Jun 26, 2020
| } // namespace rcpputils | ||
|
|
||
| #define RCPPUTILS_SCOPE_EXIT(code) \ | ||
| auto RCUTILS_JOIN(scope_exit_, __LINE__) = rcpputils::make_scope_exit([&]() {code;}) |
Collaborator
There was a problem hiding this comment.
RCUTILS_JOIN will be defined in rcutils, right? I was not able to find it. just want to confirm.
Author
There was a problem hiding this comment.
Author
|
@ros-pull-request-builder retest this please |
Author
|
Rolling PR job passed http://build.ros2.org/view/Rpr/job/Rbin_uF64__rcpputils__ubuntu_focal_amd64__binary/5/ |
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
added a commit
that referenced
this pull request
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of
rclcpp's. Can be cancelled.