support wildcard matching for params file#987
Merged
fujitatomoya merged 3 commits intoros2:rollingfrom Sep 8, 2022
Merged
Conversation
added 3 commits
August 9, 2022 12:44
Contributor
Author
|
CI:
|
ivanpauno
approved these changes
Aug 23, 2022
Member
|
@fujitatomoya @iuhilnehc-ynos is this ready to be merged? |
Collaborator
|
@Mergifyio backport humble galactic |
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) # Conflicts: # rclpy/src/rclpy/node.cpp
Contributor
✅ Backports have been createdDetails
|
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 9, 2022
* support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) Co-authored-by: Chen Lihui <lihui.chen@sony.com>
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 9, 2022
* support wildcard matching for params file (#987) * support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) # Conflicts: # rclpy/src/rclpy/node.cpp * resolve conflict (#1004) * resolve conflict Signed-off-by: Chen Lihui <lihui.chen@sony.com> * cpp headers should be put after c Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * ament_cpplint recognizes headers with extensions in angle brackets as c system headers (#1005) excepts some headers defines in _CPP_HEADERS Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
tonynajjar
pushed a commit
to pixel-robotics/rclpy
that referenced
this pull request
Sep 10, 2022
) * support wildcard matching for params file (ros2#987) * support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) # Conflicts: # rclpy/src/rclpy/node.cpp * resolve conflict (ros2#1004) * resolve conflict Signed-off-by: Chen Lihui <lihui.chen@sony.com> * cpp headers should be put after c Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * ament_cpplint recognizes headers with extensions in angle brackets as c system headers (ros2#1005) excepts some headers defines in _CPP_HEADERS Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
* support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) Co-authored-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to address ros2/rclcpp#1839 (comment)