support wildcard matching for params file (backport #987)#1003
Merged
fujitatomoya merged 3 commits intogalacticfrom Sep 9, 2022
Merged
support wildcard matching for params file (backport #987)#1003fujitatomoya merged 3 commits intogalacticfrom
fujitatomoya merged 3 commits intogalacticfrom
Conversation
* support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) # Conflicts: # rclpy/src/rclpy/node.cpp
Collaborator
|
@iuhilnehc-ynos could you help to resolve conflict? |
Contributor
|
I don't have permission to push a commit into |
Merged
* resolve conflict Signed-off-by: Chen Lihui <lihui.chen@sony.com> * cpp headers should be put after c Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
|
CI:
|
Merged
… c system headers (#1005) excepts some headers defines in _CPP_HEADERS Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
|
Collaborator
|
Collaborator
|
unstable warnings are unrelated. |
tonynajjar
pushed a commit
to pixel-robotics/rclpy
that referenced
this pull request
Sep 10, 2022
) * support wildcard matching for params file (ros2#987) * support regex for params file Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * flake8 Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit 3586009) # Conflicts: # rclpy/src/rclpy/node.cpp * resolve conflict (ros2#1004) * resolve conflict Signed-off-by: Chen Lihui <lihui.chen@sony.com> * cpp headers should be put after c Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * ament_cpplint recognizes headers with extensions in angle brackets as c system headers (ros2#1005) excepts some headers defines in _CPP_HEADERS Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #987 done by Mergify.
Cherry-pick of 3586009 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com