Skip to content

Use absolute parameter events topic name#612

Merged
jacobperron merged 1 commit intomasterfrom
ivanpauno/absolute-parameters-events-topic
Aug 4, 2020
Merged

Use absolute parameter events topic name#612
jacobperron merged 1 commit intomasterfrom
ivanpauno/absolute-parameters-events-topic

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Follow up of ros2/rclcpp#929.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 3, 2020
@ivanpauno ivanpauno requested a review from jacobperron August 3, 2020 19:24
@ivanpauno ivanpauno self-assigned this Aug 3, 2020
@jacobperron
Copy link
Copy Markdown
Member

jacobperron commented Aug 3, 2020

Sorry, missed this before opening my own (#613)

@jacobperron
Copy link
Copy Markdown
Member

jacobperron commented Aug 3, 2020

Note, I've already triggered a full CI run (together with the rclcpp change):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated test failures in rcl)

@jacobperron jacobperron merged commit 1bdd3ce into master Aug 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/absolute-parameters-events-topic branch August 4, 2020 01:40
jacobperron pushed a commit that referenced this pull request Aug 6, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
crystaldust pushed a commit to crystaldust/rclpy that referenced this pull request Sep 10, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron added a commit that referenced this pull request Nov 6, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants