[foxy backport] Use absolute parameter events topic name (#612)#614
Merged
jacobperron merged 1 commit intofoxyfrom Nov 6, 2020
Merged
[foxy backport] Use absolute parameter events topic name (#612)#614jacobperron merged 1 commit intofoxyfrom
jacobperron merged 1 commit intofoxyfrom
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
approved these changes
Aug 6, 2020
Member
Author
|
Contributor
|
@jacobperron are the windows CI failures unrelated too? |
Member
Author
|
I'm not sure about the Windows failures, triggering a regular Foxy job for comparison: |
Member
Author
|
I'm pretty sure all the windows failures are unrelated. The only one that I don't recall seeing before is this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #612 to Foxy.