Use params from node '/**' from parameter YAML file#370
Merged
Conversation
Member
Author
|
CI:
|
Member
Author
|
I'm completely new to Python's C API, so if anything looks wonky, speak up. |
jacobperron
reviewed
Jun 18, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
I feel like this sort of parameter parsing would be better implemented in rcl layer so all client libraries can take advantage.
d1353c1 to
db4f6e5
Compare
The short-term goal of this change is to enable the creation of a parameter YAML file which is applied to each node, regardless of node name or namespace. Future work is to support all wildcard syntax in node names in parameter YAML files. Signed-off-by: Scott K Logan <logans@cottsay.net>
db4f6e5 to
c01866a
Compare
jacobperron
approved these changes
Jun 21, 2019
cottsay
added a commit
that referenced
this pull request
Jul 31, 2019
The short-term goal of this change is to enable the creation of a parameter YAML file which is applied to each node, regardless of node name or namespace. Future work is to support all wildcard syntax in node names in parameter YAML files. This is a backport of #370 for Dashing. Signed-off-by: Scott K Logan <logans@cottsay.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short-term goal of this change is to enable the creation of a parameter YAML file which is applied to each node, regardless of node name or namespace.
Future work is to support all wildcard syntax in node names in parameter YAML files.