Skip to content

[Backport] Use params from node '/**' from parameter YAML file#399

Merged
cottsay merged 1 commit intodashingfrom
wildcard_param_yaml
Jul 31, 2019
Merged

[Backport] Use params from node '/**' from parameter YAML file#399
cottsay merged 1 commit intodashingfrom
wildcard_param_yaml

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Jul 29, 2019

This is a backport of #370 for Dashing.


The short-term goal of this change is to enable the creation of a parameter YAML file which is applied to each node, regardless of node name or namespace.

Future work is to support all wildcard syntax in node names in parameter YAML files.

@cottsay cottsay added the in review Waiting for review (Kanban column) label Jul 29, 2019
@cottsay cottsay self-assigned this Jul 29, 2019
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Jul 31, 2019

@ros-pull-request-builder retest this please

@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Jul 31, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

The short-term goal of this change is to enable the creation of a
parameter YAML file which is applied to each node, regardless of node
name or namespace.

Future work is to support all wildcard syntax in node names in
parameter YAML files.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the wildcard_param_yaml branch from 2364df4 to 0cbd53b Compare July 31, 2019 18:13
@cottsay cottsay merged commit b6757d6 into dashing Jul 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the wildcard_param_yaml branch July 31, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants