Skip to content

add QoS Profile/Depth support to Node.#1376

Merged
ahcorde merged 4 commits intorollingfrom
fujitatomoya/node-rosout-qos-profile-support
Jan 30, 2025
Merged

add QoS Profile/Depth support to Node.#1376
ahcorde merged 4 commits intorollingfrom
fujitatomoya/node-rosout-qos-profile-support

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Nov 3, 2024 •
edited
Loading

closes #1368

depends on ros2/rmw#381

@fujitatomoya fujitatomoya mentioned this pull request Nov 3, 2024
Closed
fujitatomoya
fujitatomoya commented Nov 3, 2024
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 3, 2024

@ahcorde @clalancette please take a look if you have time.

ahcorde
ahcorde requested changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is failing https://build.ros2.org/job/Rpr__rclpy__ubuntu_noble_amd64/400/

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 4, 2024

Pulls: #1376
Gist: https://gist.githubusercontent.com/fujitatomoya/2288c082a6b12e1b69cb9fa1878b9ffc/raw/a5f536d8bd4673a5e2b08457b15bffc4b3d52e55/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14780

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya requested a review from ahcorde November 4, 2024 20:07
clalancette
clalancette requested changes Nov 4, 2024
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 4, 2024

@clalancette thanks for the review and information. i agree with your comments, i will try to address them.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 987bc36 to 1e5a670 Compare November 6, 2024 20:36
@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2024
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 6, 2024

@clalancette this is ready to review.

to expose default rosout qos profile to rclpy, it requires the following changes.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 19, 2024

either @clalancette or @ahcorde friendly ping.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 19, 2024

Pulls: #1376, ros2/rmw#381, ros2/rcl#1195, ros2/rclcpp#2663
Gist: https://gist.githubusercontent.com/fujitatomoya/e4ad476b64d3f274940ae31ebe7149e3/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy rmw rcl rclcpp
TEST args: --packages-above rclpy rmw rcl rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14837

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Nov 19, 2024
Merged
Merged
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 20, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Dec 1, 2024

@ahcorde @clalancette CI failures are unrelated to these changes, i would like to request the reviews. (see #1376 (comment))

@fujitatomoya
add QoS Profile/Depth support to Node.
e83bf0c 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
address flake8 warnings.
10d292e 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
support qos_profile_rosout_default.
0bfefdf 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
address flake8 warnings.
69f8353 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 774696e to 69f8353 Compare January 18, 2025 01:15
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 18, 2025

@ahcorde can you review this? all the other PRs are approved, after this approval, i will start the CI all together.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 22, 2025

Pulls: ros2/rcl#1195, ros2/rmw#381, ros2/rclcpp#2663, #1376
Gist: https://gist.githubusercontent.com/fujitatomoya/259af27c06fabca14048f5367b8552af/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15081

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 22, 2025 •
edited
Loading

Pulls: ros2/rcl#1195, ros2/rmw#381, ros2/rclcpp#2663, #1376
Gist: https://gist.githubusercontent.com/fujitatomoya/94630b0c6cc669a66b03c18a1487f1d8/raw/eda21354a124f2ef7073c211f8325ed696bb886a/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15082

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 24, 2025

@ahcorde can you review this and approve? all other PRs are ready to go, and CI is green.

@ahcorde ahcorde merged commit 25a3cf3 into rolling Jan 30, 2025
@ahcorde ahcorde deleted the fujitatomoya/node-rosout-qos-profile-support branch January 30, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@clalancette clalancette

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No way to set rosout QoS for a Node

3 participants

@fujitatomoya @ahcorde @clalancette