Skip to content

move qos_profile_rosout_default to rmw.#1195

Merged
ahcorde merged 3 commits intorollingfrom
fujitatomoya/node-rosout-qos-profile-support
Jan 30, 2025
Merged

move qos_profile_rosout_default to rmw.#1195
ahcorde merged 3 commits intorollingfrom
fujitatomoya/node-rosout-qos-profile-support

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Nov 6, 2024

depends on ros2/rmw#381

@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2024
Merged
fujitatomoya
fujitatomoya commented Nov 6, 2024
View reviewed changes
This was referenced Nov 6, 2024
Merged
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Nov 19, 2024

Pulls: ros2/rclpy#1376, ros2/rmw#381, #1195, ros2/rclcpp#2663
Gist: https://gist.githubusercontent.com/fujitatomoya/e4ad476b64d3f274940ae31ebe7149e3/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy rmw rcl rclcpp
TEST args: --packages-above rclpy rmw rcl rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14837

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 5716579 to 43e33ee Compare January 18, 2025 01:13
@fujitatomoya
move qos_profile_rosout_default to rmw.
b5071ee 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
keep rcl_qos_profile_rosout_default with deprecation warning.
f9ef0ba 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 43e33ee to f9ef0ba Compare January 22, 2025 20:28
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 22, 2025

Pulls: #1195, ros2/rmw#381, ros2/rclcpp#2663, ros2/rclpy#1376
Gist: https://gist.githubusercontent.com/fujitatomoya/259af27c06fabca14048f5367b8552af/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15081

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 22, 2025

https://ci.ros2.org/job/ci_windows/23193/console windows is not happy with C:\ci\ws\src\ros2\rcl\rcl\include\rcl/logging_rosout.h(41,95): error C2099: initializer is not a constant (compiling source file C:\ci\ws\src\ros2\rcl\rcl\src\rcl\logging.c).

@fujitatomoya
make windows happy.
cf86132 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jan 22, 2025 •
edited
Loading

Pulls: #1195, ros2/rmw#381, ros2/rclcpp#2663, ros2/rclpy#1376
Gist: https://gist.githubusercontent.com/fujitatomoya/94630b0c6cc669a66b03c18a1487f1d8/raw/eda21354a124f2ef7073c211f8325ed696bb886a/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15082

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit c9b3220 into rolling Jan 30, 2025
@ahcorde ahcorde deleted the fujitatomoya/node-rosout-qos-profile-support branch January 30, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@audrow audrow Awaiting requested review from audrow

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @ahcorde