[eloquent backport] Intra-process subscriber should use RMW actual qos. (ros2#913) (#914)#965
Merged
jacobperron merged 1 commit intoeloquentfrom Jan 17, 2020
Merged
Conversation
mjcarroll
approved these changes
Jan 17, 2020
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Only check wait_set->impl for NULL pointer. The previous line already checked wait_set for NULL pointer, so there is no reason to call rcl_wait_set_is_valid and recheck that pointer. * Remove some debug statements from rcl_wait. While profiling an application, I found that a lot of time was spent just checking whether a log message should be output or not based on the current debug level. None of the individual calls are expensive, but since rcl_wait is called so often, it ends up showing up in the profile. This patch somewhat controversially removes the debug statements from rcl_wait(). My view on it is that the utility of these is fairly low (if you ever turned them on, you would be flooded with information), and the cost is relatively high. If you are really debugging this stuff, you can add in your own, more targeted debug statements or use a debugger. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #914 to Eloquent.