Closed
Conversation
* timeout was not required since the request will fail if the node is not found Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Member
|
Removing this timeout here doesn't make any sense imo. If the call doesn't finish within 5s it is extremely unlikely that it will finish in the remaining time of the (usually using a CTest timeout of 30 or 60 seconds). Though if it fails to complete within 5s it is safe to fail the test. The node not being found is only one of the possible scenarios. It can absolutely happen that the node was found and the request sent but no response is ever received. And in that case the explicit timeout makes sure the test fails quickly. |
Member
Contributor
Author
|
The intention of this PR was to improve stability with this test. Instead it looks like there's another underlying issue. There's an open issue on the flakiness of this test here: #863 |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Stephen Brawner <brawner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zachary Michaels zmichaels11@gmail.com