Skip to content

Aggregate all component manager API tests.#876

Merged
hidmic merged 1 commit intomasterfrom
hidmic/change-components-test
Sep 26, 2019
Merged

Aggregate all component manager API tests.#876
hidmic merged 1 commit intomasterfrom
hidmic/change-components-test

Conversation

@hidmic
Copy link
Copy Markdown
Contributor

@hidmic hidmic commented Sep 26, 2019

Connected to #863. Not very proud of it but it'll get us back to green in CI till races are actually solved.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from mjcarroll September 26, 2019 19:05
@hidmic
Copy link
Copy Markdown
Contributor Author

hidmic commented Sep 26, 2019

CI up to rclcpp_components:

  • Linux Build Status
  • Arch Build Status
  • Windows Build Status
  • OSX Build Status

Copy link
Copy Markdown
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but makes CI happy, so LGTM.

@hidmic hidmic merged commit 4afd1cd into master Sep 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/change-components-test branch September 26, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants