[dashing backport] add mutex in add/remove_node and wait_for_work to protect concurrent use/change of memory_strategy_#857
[dashing backport] add mutex in add/remove_node and wait_for_work to protect concurrent use/change of memory_strategy_#857tfoote merged 1 commit intoros2:dashingfrom zmichaels11:zmichaels11/backport-#837
Conversation
…use/change of memory_strategy_ (#837) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
|
Please use the prefix "[dashing backport] " in the title to make it obvious that this is a backport. Also please reference the ticket which is being backported here. |
|
Backporting PR #837 to Dashing |
No, the PR number doesn't get converted into a reference when it is in the title. |
|
@zmichaels11 All the CI's failed on this. the linux one looks like jenkins lost connection during the build so I restarted it. But all the others look to have failed real failures. |
|
I'm looking into why its failing locally. |
|
I think you have the same problem that you're testing it against master not dashing https://github.com/ros2/ros2/blob/dashing/ros2.repos |
|
It looks like that fixed the other PR.
|
|
@tfoote it looks like it was the same problem; all builds are passing |
|
@ros-pull-request-builder retest this please |
|
@zmichaels11 It seems that the PR build has repeatedly the same test failure which doesn't appear in the dev job so it might be related to this change. |
|
@dirk-thomas The tests fail due to |
|
Possible fix for this PR: #862 |
tfoote
left a comment
There was a problem hiding this comment.
After looking around a little it seems that this is an existing issue that the PR jobs now hitting more often. ros2/build_farmer#184
It's come up in several other dashing backports such as #799 to that end I'm going to merge as is since the CI is passing and that the behavior has been seen on the dev jobs as well indicates that it's not a regression caused by this change.
* refactor for removing unnecessary source code Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Zachary Michaels zmichaels11@gmail.com