Merged
Conversation
Provides a virtual API for interacting with wait sets.
sloretz
reviewed
Nov 21, 2018
02a5ca7 to
908d9a1
Compare
hidmic
reviewed
Nov 21, 2018
Contributor
hidmic
left a comment
There was a problem hiding this comment.
LGTM but for a small doubt
| timer_handles_[i].reset(); | ||
| } | ||
| } | ||
| for (size_t i = 0; i < timer_handles_.size(); ++i) { |
Contributor
There was a problem hiding this comment.
@jacobperron twice on timers? I feel like I'm missing something here.
Contributor
|
@jacobperron one CI run and this guy is good to go. |
Contributor
|
Should add |
Member
Author
Thanks, LGTM. |
Member
Author
|
With tests:
|
Contributor
|
Member
Author
|
Rebuild:
|
Contributor
|
I believe Windows is failing because those |
Member
Author
|
Windows: |
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* [rclcpp] Add class Waitable Provides a virtual API for interacting with wait sets. * [rclcpp] Add node interface for Waitables * [rclcpp] Implement node interface for Waitables * [rclcpp] Integrate Waitable entities with executor * Implement remaining logic for integrating Waitables * Add visibility macros and other refactoring to Waitable class * Return zero size for entities in a Waitable by default * Bugfix: Clear list of waitable handles * Bugfix: update Waitable handle list based on readiness * Bugfix: update for loop condition * Give node a node_waitables_ * Give lifecycle node a node_waitables
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a virtual API for interacting with wait sets.
Closes #588