Skip to content

Subscription tests using bind in member callback#480

Merged
dhood merged 4 commits intomasterfrom
decltype_gcc7
Jun 4, 2018
Merged

Subscription tests using bind in member callback#480
dhood merged 4 commits intomasterfrom
decltype_gcc7

Conversation

@dhood
Copy link
Copy Markdown
Member

@dhood dhood commented May 29, 2018

Highlights #479 (9d5b035 does not compile with gcc7)

@dhood dhood mentioned this pull request May 31, 2018
Closed
@esteve esteve mentioned this pull request May 31, 2018
Merged
@dhood dhood added the in review Waiting for review (Kanban column) label Jun 1, 2018
@dhood
Copy link
Copy Markdown
Member Author

dhood commented Jun 1, 2018

@esteve submitted a fix in #484

CI of a branch that includes this branch and that one, using bionic (to check the regression test passes):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

I consider these tests to be the "applied" form of the "pure" function_traits tests (e.g. https://github.com/ros2/rclcpp/pull/484/files#diff-f5a3b9e4911ad480cffef8c3e8f30b5eR725). These tests will still be relevant even if we get rid of function_traits one day (as @wjwwood mentioned to me is a possibility the other day), so I'd still put these tests forward for review if others agree.

@dhood dhood self-assigned this Jun 1, 2018
@dhood
Copy link
Copy Markdown
Member Author

dhood commented Jun 2, 2018

linter fixes:

  • Linux Build Status
  • macOS Build Status
  • Windows Build Status

mikaelarguedas
mikaelarguedas approved these changes Jun 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhood dhood merged commit 2a17232 into master Jun 4, 2018
@dhood dhood deleted the decltype_gcc7 branch June 4, 2018 19:48
@dhood dhood removed the in review Waiting for review (Kanban column) label Jun 4, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@mikaelarguedas @dirk-thomas
Improve security error messages (ros2#480)
6f20cd9 
* Prints the node name when failing to find security directory

Also quotes directory, node_name and lookup strategy in error message for readability

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* don't quote lookup strategy

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* newline -> whitespace

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dhood dhood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhood @mikaelarguedas