Relax template matching rules for std::bind and GNU C++ >= 7.1#484
Merged
dhood merged 2 commits intoros2:masterfrom Jun 1, 2018
Merged
Relax template matching rules for std::bind and GNU C++ >= 7.1#484dhood merged 2 commits intoros2:masterfrom
dhood merged 2 commits intoros2:masterfrom
Conversation
Member
Author
Member
|
Thanks @esteve ! I tested this patch in a tb2 workspace on bionic and it does fix the compilation error 👍 |
Member
|
CI:
|
Member
Author
|
@mikaelarguedas no worries, let me know if there's anything else that needs to be fixed/improved. @dhood I just noticed that you had submitted #480 to highlight #479. Sorry, I hadn't seen it before submitting this PR. I believe 9d5b035#diff-36b58065fa9e8269e336f296c41cdf4cR125 should pass now 🤞 |
Member
|
No worries, thanks for taking a look at it! |
dhood
approved these changes
Jun 1, 2018
Member
Author
|
@dhood anytime! :-) Feel free to ping me again if there's something in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to #479