Skip to content

Remove duplicate test cases in TestAnySubscriptionCallback::is_serialized_message_callback#3104

Merged
fujitatomoya merged 1 commit intoros2:rollingfrom
Zyrin:remove_some_duplicate_tests
Mar 21, 2026
Merged

Remove duplicate test cases in TestAnySubscriptionCallback::is_serialized_message_callback#3104
fujitatomoya merged 1 commit intoros2:rollingfrom
Zyrin:remove_some_duplicate_tests

Conversation

@Zyrin
Copy link
Copy Markdown
Contributor

@Zyrin Zyrin commented Mar 20, 2026

Description

I found some test cases that were implemented twice, so I removed them. So this us just a bit of "cleanup".

Is this user-facing behavior change?

No

Did you use Generative AI?

No

remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
0d2b193 
…ized_message_callback

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
@Zyrin Zyrin force-pushed the remove_some_duplicate_tests branch from cb64fd8 to 0d2b193 Compare March 20, 2026 10:25
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 20, 2026

Pulls: #3104
Gist: https://gist.githubusercontent.com/ahcorde/27028e5f61fc4262d74e6f2c985e76fe/raw/13d014a0cb80d3950cc82ced438105fff5126832/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18580

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Mar 21, 2026

@Zyrin thanks for the PR, good eye 👍

@fujitatomoya fujitatomoya merged commit af78e01 into ros2:rolling Mar 21, 2026
2 of 3 checks passed
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Mar 21, 2026

@Mergifyio backport kilted jazzy humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 21, 2026 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

Cherry-pick of af78e01 has failed:

On branch mergify/bp/kilted/pr-3104
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit af78e01.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/test_any_subscription_callback.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of af78e01 has failed:

On branch mergify/bp/jazzy/pr-3104
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit af78e01.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/test_any_subscription_callback.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of af78e01 has failed:

On branch mergify/bp/humble/pr-3104
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit af78e01.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/test_any_subscription_callback.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Mar 21, 2026
@Zyrin @mergify
remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
64898e1 
…ized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)

# Conflicts:
#	rclcpp/test/rclcpp/test_any_subscription_callback.cpp
@mergify mergify bot mentioned this pull request Mar 21, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 21, 2026
@Zyrin @mergify
remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
ea89854 
…ized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)

# Conflicts:
#	rclcpp/test/rclcpp/test_any_subscription_callback.cpp
@mergify mergify bot mentioned this pull request Mar 21, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 21, 2026
@Zyrin @mergify
remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
e189b7e 
…ized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)

# Conflicts:
#	rclcpp/test/rclcpp/test_any_subscription_callback.cpp
@mergify mergify bot mentioned this pull request Mar 21, 2026
Merged
ahcorde pushed a commit that referenced this pull request Mar 23, 2026
@mergify @Zyrin @fujitatomoya
Remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
376e273 
…ized_message_callback (backport #3104) (#3106)

* remove duplicate test cases in TestAnySubscriptionCallback::is_serialized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)

# Conflicts:
#	rclcpp/test/rclcpp/test_any_subscription_callback.cpp

* resolve conflicts.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alexis Tsogias <1114095+Zyrin@users.noreply.github.com>
Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request Mar 23, 2026
@mergify @Zyrin @fujitatomoya
Remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
140a753 
…ized_message_callback (backport #3104) (#3107)

* remove duplicate test cases in TestAnySubscriptionCallback::is_serialized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alexis Tsogias <1114095+Zyrin@users.noreply.github.com>
Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request Mar 23, 2026
@mergify @Zyrin @fujitatomoya
Remove duplicate test cases in TestAnySubscriptionCallback::is_serial…
97c89af 
…ized_message_callback (backport #3104) (#3108)

* remove duplicate test cases in TestAnySubscriptionCallback::is_serialized_message_callback (#3104)

Signed-off-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
Co-authored-by: Ubuntu <ubuntu@ubuntu-2404-ros-rolling.lxd>
(cherry picked from commit af78e01)


Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alexis Tsogias <1114095+Zyrin@users.noreply.github.com>
Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@jmachowinski jmachowinski jmachowinski approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zyrin @ahcorde @fujitatomoya @jmachowinski