Skip to content

keep the event alive throught the assertion, preveiting the race.#3099

Merged
jmachowinski merged 1 commit intorollingfrom
fujitatomoya/fix-test_node_graph
Mar 17, 2026
Merged

keep the event alive throught the assertion, preveiting the race.#3099
jmachowinski merged 1 commit intorollingfrom
fujitatomoya/fix-test_node_graph

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Mar 17, 2026

Description

Part of ros2/rmw_cyclonedds#550

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya
keep the event alive throught the assertion, preveiting the race.
0b04394 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 17, 2026

Pulls: #3099
Gist: https://gist.githubusercontent.com/fujitatomoya/a69411de365eabf77cac88100d4a3b01/raw/d9bfc38a069f26a9bdfef222a0526000e77cfed1/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp --cmake-args -DRMW_IMPLEMENTATION=rmw_cyclonedds_cpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18511

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-assigned this Mar 17, 2026
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 17, 2026

Pulls: #3099
Gist: https://gist.githubusercontent.com/fujitatomoya/eeb4e623776d704272dbd958af9c86f5/raw/d9bfc38a069f26a9bdfef222a0526000e77cfed1/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18512

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski merged commit aadcb3b into rolling Mar 17, 2026
2 of 3 checks passed
@jmachowinski
Copy link
Copy Markdown
Collaborator

jmachowinski commented Mar 17, 2026

@Mergifyio backport jazzy humble kilted

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 17, 2026 •
edited
Loading

backport jazzy humble kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 17, 2026
@fujitatomoya @mergify
keep the event alive throught the assertion, preveiting the race. (#3099
2cccccf 
)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit aadcb3b)
@mergify mergify bot mentioned this pull request Mar 17, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 17, 2026
@fujitatomoya @mergify
keep the event alive throught the assertion, preveiting the race. (#3099
3d0829e 
)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit aadcb3b)
@mergify mergify bot mentioned this pull request Mar 17, 2026
Merged
mergify bot pushed a commit that referenced this pull request Mar 17, 2026
@fujitatomoya @mergify
keep the event alive throught the assertion, preveiting the race. (#3099
19c26db 
)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit aadcb3b)
@mergify mergify bot mentioned this pull request Mar 17, 2026
Merged
fujitatomoya added a commit that referenced this pull request Mar 17, 2026
@mergify @fujitatomoya
keep the event alive throught the assertion, preveiting the race. (#3099
67d29d1 
) (#3100)

(cherry picked from commit aadcb3b)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Mar 17, 2026
@mergify @fujitatomoya
keep the event alive throught the assertion, preveiting the race. (#3099
dca23fe 
) (#3101)

(cherry picked from commit aadcb3b)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Mar 17, 2026
@mergify @fujitatomoya
keep the event alive throught the assertion, preveiting the race. (#3099
68adae6 
) (#3102)

(cherry picked from commit aadcb3b)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 17, 2026

@jmachowinski thanks for starting CI for backport PRs, all merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @jmachowinski @mjcarroll