Skip to content

Switch to isolated testing via rmw_test_fixture#2929

Merged
ahcorde merged 3 commits intorollingfrom
yadu/rmw_test_fixture
Nov 25, 2025
Merged

Switch to isolated testing via rmw_test_fixture#2929
ahcorde merged 3 commits intorollingfrom
yadu/rmw_test_fixture

Conversation

@Yadunund
Copy link
Copy Markdown
Member

@Yadunund Yadunund commented Aug 8, 2025

Description

This PR effectively reverts #2776 and relies on rmw_test_fixture to start a zenoh router when testing with rmw_zenoh.

Fixes # (issue)

Partially addresses ros2/ros2#1664

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

rclcpp/CMakeLists.txt already calls find_package(ament_cmake_ros REQUIRED).

@Yadunund
Switch to rmw_test_fixture for isolated testing
72d7d65 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund mentioned this pull request Aug 8, 2025
Open
15 tasks
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Aug 18, 2025

Pulls: #2929
Gist: https://gist.githubusercontent.com/ahcorde/436918e6cfa2098431afbe782c400999/raw/168dacfcbbb5e9de67dc68148bb21245279a3ccb/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16734

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Yadunund
Fix macro name
4c71783 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund
Copy link
Copy Markdown
Member Author

Yadunund commented Aug 21, 2025

Pulls: #2929
Gist: https://gist.githubusercontent.com/ahcorde/436918e6cfa2098431afbe782c400999/raw/168dacfcbbb5e9de67dc68148bb21245279a3ccb/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16766

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Yadunund Yadunund requested a review from cottsay August 21, 2025 17:53
cottsay
cottsay requested changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

rclcpp/package.xml
Comment on lines -50 to -52
<test_depend>ament_cmake_gmock</test_depend>
<test_depend>ament_cmake_google_benchmark</test_depend>
<test_depend>ament_cmake_gtest</test_depend>
Copy link
Copy Markdown
Member

@cottsay cottsay Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still un-isolated gmock/gtest tests in this package, so I think these dependencies should stay.

@ahcorde
Restored dependency
b5d1c5d 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 21, 2025 •
edited
Loading

Pulls: #2929
Gist: https://gist.githubusercontent.com/ahcorde/0d78f7f4bd787b6c5512424fbcaced28/raw/bab12c7b00b7de38ec5acbb372f61c204d979abe/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17572

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 25, 2025

Warnings are unrelated. Merging

@ahcorde ahcorde merged commit 1500449 into rolling Nov 25, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the yadu/rmw_test_fixture branch November 25, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cottsay cottsay cottsay requested changes

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yadunund @ahcorde @mjcarroll @cottsay @fujitatomoya