Skip to content

Shutdown deadlock fix jazzy (backport #2887)#2888

Merged
jmachowinski merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2887
Jul 3, 2025
Merged

Shutdown deadlock fix jazzy (backport #2887)#2888
jmachowinski merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2887

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 2, 2025

Description

ABI compatible backport of #2886


This is an automatic backport of pull request #2887 done by [Mergify](https://mergify.com).

* fix: Don't deadlock if removing shutdown callbacks in a shutdown callback

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

* refactor: Made fix API compatible

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

---------

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
(cherry picked from commit 7aab9b6)
@mergify mergify bot mentioned this pull request Jul 2, 2025
@fujitatomoya fujitatomoya requested a review from jmachowinski July 2, 2025 16:33
@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2888
Gist: https://gist.githubusercontent.com/fujitatomoya/997c3449bcebd561e0e441900b291514/raw/31b78f6f74433df987617380de7657e2d3756b6d/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16389

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@jmachowinski can you approve this?

@jmachowinski jmachowinski merged commit a5a7feb into kilted Jul 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants