fix: Don't deadlock if removing shutdown callbacks in a shutdown callback#2886
Merged
ahcorde merged 3 commits intoros2:rollingfrom Jul 2, 2025
Merged
Conversation
ahcorde
requested changes
Jun 30, 2025
…back Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
21f9c92 to
e03a2cf
Compare
Collaborator
Author
|
Pulls: #2886
|
ahcorde
approved these changes
Jul 1, 2025
fujitatomoya
approved these changes
Jul 1, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with nitpicks. (i think restarting CI is not required, because they are just comment fixes.)
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
Collaborator
Author
|
All test failures seem unrelated, @ahcorde do you agree ? |
Contributor
Yes, all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a deadlock, if a shutdown callback was removed during a shutdown callback.
Is this user-facing behavior change?
Yes, the users nodes do not hang any more on shutdown under special conditions.
Did you use Generative AI?
No