Conversation
…egmentation fault (#2840) * get_all_data_impl() does not handle null pointers properly, causing segmentation fault Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * make linters happy Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> (cherry picked from commit 6c47883) # Conflicts: # rclcpp/test/rclcpp/test_ring_buffer_implementation.cpp
Contributor
Author
|
Cherry-pick of 6c47883 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
|
Pulls: #2850
|
ahcorde
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #2829
This is an automatic backport of pull request #2840 done by Mergify.