get_all_data_impl() does not handle null pointers properly, causing segmentation fault#2840
Merged
get_all_data_impl() does not handle null pointers properly, causing segmentation fault#2840
Conversation
…egmentation fault Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
jmachowinski
requested changes
May 15, 2025
rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp
Outdated
Show resolved
Hide resolved
fujitatomoya
approved these changes
May 15, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
i am okay with @jmachowinski 's suggestion too, that probably better readability 👍
…ntation.hpp Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Contributor
Author
|
Pulls: #2840
|
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
Author
|
alsora
approved these changes
May 17, 2025
Collaborator
|
The CI failure is unrelated and the requested change has been addressed. |
Contributor
Author
|
https://github.com/Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
…egmentation fault (#2840) * get_all_data_impl() does not handle null pointers properly, causing segmentation fault Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * make linters happy Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> (cherry picked from commit 6c47883) # Conflicts: # rclcpp/test/rclcpp/test_ring_buffer_implementation.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
…egmentation fault (#2840) * get_all_data_impl() does not handle null pointers properly, causing segmentation fault Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * make linters happy Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> (cherry picked from commit 6c47883) # Conflicts: # rclcpp/test/rclcpp/test_ring_buffer_implementation.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
…egmentation fault (#2840) * get_all_data_impl() does not handle null pointers properly, causing segmentation fault Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * make linters happy Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> (cherry picked from commit 6c47883) # Conflicts: # rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp # rclcpp/test/rclcpp/test_ring_buffer_implementation.cpp
skyegalaxy
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
Jul 28, 2025
* QoSInitialization::from_rmw does not validate invalid history policy values, leading to silent failures (ros2#2841) (ros2#2845) (cherry picked from commit 73e9bfb) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * get_all_data_impl() does not handle null pointers properly, causing segmentation fault (backport ros2#2840) (ros2#2851) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added missing chrono includes (ros2#2854) (ros2#2856) (cherry picked from commit 373a63c) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix for memory leaks in rclcpp::SerializedMessage (ros2#2861) (ros2#2864) (cherry picked from commit 8d44b95) Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <morlovmr@gmail.com> Co-authored-by: kylemarcey <marcey.kyle@gmail.com> * Replace std::default_random_engine with std::mt19937 (humble) (ros2#2847) (ros2#2867) (cherry picked from commit a0e2240) Signed-off-by: keeponoiro <keeeeeeep@gmail.com> Co-authored-by: keeponoiro <keeeeeeep@gmail.com> * Changelog Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * 28.1.10 * fix test_publisher_with_system_default_qos. (ros2#2881) (ros2#2883) (cherry picked from commit e6577c6) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Shutdown deadlock fix jazzy (ros2#2887) * fix: Don't deadlock if removing shutdown callbacks in a shutdown callback Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * refactor: Made fix API compatible Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> --------- Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> * Event exec timer fix for ros2#2889 (ros2#2890) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Add overload of `append_parameter_override` (ros2#2891) (ros2#2895) (cherry picked from commit fa0cf2d) Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com> * Fujitatomoya/test append parameter override (ros2#2896) (ros2#2900) (cherry picked from commit 84c6fb1) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * [jazzy] Expose `typesupport_helpers` API needed for the Rosbag2 (backport ros2#2858) (ros2#2902) * Expose `typesupport_helpers` API needed for the Rosbag2 (ros2#2858) * Expose extract_type_identifier and get_typesupport_library_path API - Rationale: We need to use this API in the Rosbag2 - Reference PR ros2/rosbag2#2017 in the Rosbag2 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use C++ style in doxygen documentation Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 448287b) # Conflicts: # rclcpp/include/rclcpp/typesupport_helpers.hpp * Address merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <morlovmr@gmail.com> * Add qos parameter for wait_for_message function (ros2#2903) (ros2#2906) (cherry picked from commit 2fcef70) Signed-off-by: Sriharsha Ghanta <ghanta1996@gmail.com> Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Sriharsha Ghanta <ghanta_sriharsha@mymail.sutd.edu.sg> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Fix `start_type_description_service` param handling (ros2#2897) (ros2#2909) * Fix `start_type_description_service` param handling * Add test * Demonstrate different exceptions depending on node options * Same exact exception and `what()` message in both cases * Uncrustify --------- (cherry picked from commit 4fb558a) Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: keeponoiro <keeeeeeep@gmail.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> Signed-off-by: Sriharsha Ghanta <ghanta1996@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Michael Orlov <morlovmr@gmail.com> Co-authored-by: kylemarcey <marcey.kyle@gmail.com> Co-authored-by: keeponoiro <keeeeeeep@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com> Co-authored-by: Sriharsha Ghanta <ghanta_sriharsha@mymail.sutd.edu.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #2829