remove redundant typesupport check in serialization module (backport #2808)#2815
Merged
remove redundant typesupport check in serialization module (backport #2808)#2815
Conversation
Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com> (cherry picked from commit f78ed95)
Contributor
|
Pulls: #2815
|
ahcorde
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fujitatomoya
Currently, type support is also checked in individual functions, which is not needed if we check it in the constructor itself.
Is this change okay to be performed?
This is an automatic backport of pull request #2808 done by Mergify.