Skip to content

remove redundant typesupport check in serialization module#2808

Merged
ahcorde merged 1 commit intoros2:rollingfrom
izzaaaatanishq:remove_redundant_ts_check_serialization
Apr 14, 2025
Merged

remove redundant typesupport check in serialization module#2808
ahcorde merged 1 commit intoros2:rollingfrom
izzaaaatanishq:remove_redundant_ts_check_serialization

Conversation

@izzaaaatanishq
Copy link
Copy Markdown
Contributor

@izzaaaatanishq izzaaaatanishq commented Apr 13, 2025

Hi @fujitatomoya
Currently, type support is also checked in individual functions, which is not needed if we check it in the constructor itself.
Is this change okay to be performed?

ahcorde
ahcorde requested changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to sign the commit ? https://github.com/ros2/rclcpp/pull/2808/checks?check_run_id=40469640430

@izzaaaatanishq
remove redundant typesupport check in serialization module
12cd5e9 
Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
@izzaaaatanishq izzaaaatanishq force-pushed the remove_redundant_ts_check_serialization branch from 5c780f7 to 12cd5e9 Compare April 14, 2025 08:17
@izzaaaatanishq
Copy link
Copy Markdown
Contributor Author

izzaaaatanishq commented Apr 14, 2025

do you mind to sign the commit ? https://github.com/ros2/rclcpp/pull/2808/checks?check_run_id=40469640430

Performed

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 14, 2025

Pulls: #2808
Gist: https://gist.githubusercontent.com/ahcorde/167d025cf3659a08430cc28591443e27/raw/ddb64fb60c30bfe8ce8771757d84aa6cbc08e75f/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15679

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@izzaaaatanishq
Copy link
Copy Markdown
Contributor Author

izzaaaatanishq commented Apr 14, 2025

Pulls: #2808
Gist: https://gist.githubusercontent.com/ahcorde/167d025cf3659a08430cc28591443e27/raw/ddb64fb60c30bfe8ce8771757d84aa6cbc08e75f/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15679

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde do I need to do anything else from my side? Or is it ready?

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 14, 2025

Hi @Tanishq30052002 thank you for your PR, for now we need to wait to reach green CI. Once all of them are green we can merge the PR

@izzaaaatanishq
Copy link
Copy Markdown
Contributor Author

izzaaaatanishq commented Apr 14, 2025

@ahcorde Do the pipeline is going to run for linux and linux-rhel or not? I don't see them getting started.

@jmachowinski
Copy link
Copy Markdown
Collaborator

jmachowinski commented Apr 14, 2025

The Build farm is loaded with jobs, just give it some time...

fujitatomoya
fujitatomoya approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR!

@ahcorde ahcorde merged commit f78ed95 into ros2:rolling Apr 14, 2025
2 of 3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 14, 2025

https://github.com/Mergifyio backport jazzy humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 14, 2025
@izzaaaatanishq @mergify
remove redundant typesupport check in serialization module (#2808)
2ebd771 
Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
(cherry picked from commit f78ed95)
@mergify mergify bot mentioned this pull request Apr 14, 2025
Merged
mergify bot pushed a commit that referenced this pull request Apr 14, 2025
@izzaaaatanishq @mergify
remove redundant typesupport check in serialization module (#2808)
3b36d21 
Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
(cherry picked from commit f78ed95)
@mergify mergify bot mentioned this pull request Apr 14, 2025
Merged
@izzaaaatanishq izzaaaatanishq deleted the remove_redundant_ts_check_serialization branch April 14, 2025 21:46
ahcorde pushed a commit that referenced this pull request Apr 15, 2025
@mergify @izzaaaatanishq
remove redundant typesupport check in serialization module (#2808) (#…
fe6aca3 
…2815)

Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
(cherry picked from commit f78ed95)

Co-authored-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
ahcorde pushed a commit that referenced this pull request Apr 15, 2025
@mergify @izzaaaatanishq
remove redundant typesupport check in serialization module (#2808) (#…
1b040e7 
…2816)

Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
(cherry picked from commit f78ed95)

Co-authored-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@izzaaaatanishq @ahcorde @jmachowinski @fujitatomoya