ComponentManager should just ignore unknown extra argument in the bas…#2723
ComponentManager should just ignore unknown extra argument in the bas…#2723
Conversation
…e class. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@mjcarroll can you take a look? since you reviewed #2685?
| } else { | ||
| throw ComponentManagerException("Extra component argument '" + extra_argument.get_name() + | ||
| "' is not supported"); |
There was a problem hiding this comment.
this throw is added to check the unknown extra arguments in the base class.
but i do not think it should throw exception in the base class, instead it should ignore all unknown extra arguments in the base class. exception can only be thrown if the supported argument parameter type is unexpected just like before. so that child class can override this method to add more extra arguments to support. (it can actually try&catch the exception in the child class, but I think throwing exception is not correct here in the 1st place.)
this fixes the issue ros2/domain_bridge#85
|
rpr job says test also needs to be adjusted. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
Pulls: #2723
|
…e class.
closes ros2/domain_bridge#85
introduced by #2685 (only rolling has this code)