Add parsing for rest of obvious boolean extra arguments and throw for unsupported ones#2685
Merged
mjcarroll merged 2 commits intoros2:rollingfrom Dec 13, 2024
Merged
Add parsing for rest of obvious boolean extra arguments and throw for unsupported ones#2685mjcarroll merged 2 commits intoros2:rollingfrom
mjcarroll merged 2 commits intoros2:rollingfrom
Conversation
Signed-off-by: Robin Petereit <robin.petereit@tum.de>
Signed-off-by: Robin Petereit <robin.petereit@tum.de>
Member
|
Pulls: #2685
|
mjcarroll
approved these changes
Dec 13, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
this is not well-described in ros2 documentation, it is really hard to know for user what extra arguments are available. I can follow this up.
This was referenced Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves situation for #978.
Instead of arbitrarily only allowing forward_global_arguments and use_intra_process_comms as extra arguments for loading a component, this PR enables support for all obvious boolean node options.
#978 discusses more problematic options like
allow_undeclared_parameters, which are still unsupported.At least, this PR adds an error message if such or other unsupported extra arguments are passed.